Skip to content

ref(settings): remove service hooks forms and routes#116296

Merged
TkDodo merged 5 commits into
masterfrom
tkdodo/migrate-service-hooks-fieldgroup
May 28, 2026
Merged

ref(settings): remove service hooks forms and routes#116296
TkDodo merged 5 commits into
masterfrom
tkdodo/migrate-service-hooks-fieldgroup

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented May 27, 2026

these routes were not accessible in the UI and not linked to from anywhere

fixes DE-1001

…s in service hooks

Migrate projectServiceHooks and projectServiceHookDetails away from the
legacy FieldGroup form component. Both files used FieldGroup purely for
presentational layout (no form submission), so replace with Flex and Text
primitives from @sentry/scraps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 27, 2026

DE-1001

TkDodo and others added 2 commits May 27, 2026 17:40
@TkDodo TkDodo changed the title ref(settings): Replace legacy FieldGroup with Scraps layout primitives in service hooks ref(settings): remove service hooks forms and routes May 27, 2026
Copy link
Copy Markdown
Contributor

@Christinarlong Christinarlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyyyyy

@TkDodo TkDodo marked this pull request as ready for review May 28, 2026 08:43
@TkDodo TkDodo requested a review from a team as a code owner May 28, 2026 08:43
@TkDodo TkDodo merged commit ae1b06f into master May 28, 2026
71 checks passed
@TkDodo TkDodo deleted the tkdodo/migrate-service-hooks-fieldgroup branch May 28, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants